Make IterFields take in aliases #3207
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3207 +/- ##
==========================================
+ Coverage 83.57% 83.85% +0.28%
==========================================
Files 168 170 +2
Lines 15021 15315 +294
==========================================
+ Hits 12554 12843 +289
+ Misses 1729 1721 -8
- Partials 738 751 +13
|
edwardfeng-db
force-pushed
the
edwardfeng-db/iter-field-alias
branch
from
65a0442
to
8f65cbf
Compare
edwardfeng-db
requested review from
hectorcast-db and
mgyucht
and removed request for
a team
There was a problem hiding this comment.
Making good progress. Let's see if there is a way we can continue to use StructToSchema as the main entrypoint so that developers can easily switch to using this custom implementation without having to rewrite their calls to StructToSchema. This makes library code like WorkspaceData/AccountData more portable to the new model (and would immediately solve problems like #3211 is trying to solve)
clusters/resource_cluster.go
Outdated
|
|
||
| func (ClusterResourceProvider) UnderlyingType() compute.ClusterSpec { | ||
| return compute.ClusterSpec{} | ||
| type ClusterResourceProvider struct { |
There was a problem hiding this comment.
Let's just call this Cluster, in the same way that we have SqlEndpoint.
There was a problem hiding this comment.
I think Cluster is already defined, so how about naming it ClusterSpec?
There was a problem hiding this comment.
Either is better than ClusterResourceProvider :)
Changes
ResourceProviderStructtake effect initerFieldsfunction so thatStructToDataandDataToStructPointerwill take information about the aliasesUnderlyingTypemethod because it is no longer neededClusterResourceProviderstruct so that reflection will work withoutUnderlyingTypeiterFieldcheck alias informationTests
make testrun locallydocs/folderinternal/acceptance