Exporter: omit git_provider only for well-known Git URLs
#3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `git_provider` field is marked as `computed` because we're detecting it for well-known Git providers (GitHub, Azure DevOps, ...). But because of this it was omitted from the generated code even for other Git providers. This PR fixes this issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
- Coverage 83.60% 83.58% -0.03%
==========================================
Files 169 169
Lines 15094 15098 +4
==========================================
Hits 12619 12619
- Misses 1735 1737 +2
- Partials 740 742 +2
|
tanmay-db
approved these changes
Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
git_providerfield is marked ascomputedbecause we're detecting it for well-known Git providers (GitHub, Azure DevOps, ...). But because of this it was omitted from the generated code even for other Git providers. This PR fixes this issue.Tests
make testrun locallydocs/folderinternal/acceptance