Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Fix tagging workflow to identify last release properly #4437

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 27, 2025

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@mgyucht mgyucht requested review from a team as code owners January 27, 2025 14:54
@mgyucht mgyucht requested review from hectorcast-db and removed request for a team January 27, 2025 14:54
@mgyucht mgyucht temporarily deployed to test-trigger-is January 27, 2025 14:54 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 27, 2025 14:56 — with GitHub Actions Inactive
@@ -1,3 +1,3 @@
{
"timestamp": "2025-01-16 13:55:53"
"timestamp": "2025-01-27 14:59:20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a timezone to avoid ambiguity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@mgyucht mgyucht temporarily deployed to test-trigger-is January 27, 2025 15:24 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 27, 2025 15:25 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4437
  • Commit SHA: cf2a35cd52c2ae6f0f038d62051c56d3c6e6a17c

Checks will be approved automatically on success.

@mgyucht
Copy link
Contributor Author

mgyucht commented Jan 27, 2025

Merging now because this only affects the release script itself.

@mgyucht mgyucht merged commit 7db2930 into main Jan 27, 2025
9 checks passed
@mgyucht mgyucht deleted the update-tagging-script-tolerate-new-release-notes branch January 27, 2025 15:26
@mgyucht mgyucht temporarily deployed to test-trigger-is January 27, 2025 15:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants