Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Populate partitions when reading databricks_sql_table #4486

Merged
merged 11 commits into from
Feb 26, 2025
Merged

[Fix] Populate partitions when reading databricks_sql_table #4486

merged 11 commits into from
Feb 26, 2025
+200 −12

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 12, 2025 •
edited
Loading

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners February 12, 2025 02:41
@nkvuong nkvuong requested review from mgyucht and removed request for a team February 12, 2025 02:41
@alexott alexott enabled auto-merge February 12, 2025 12:38
@alexott alexott disabled auto-merge February 12, 2025 12:45
@nkvuong nkvuong changed the title [Doc] Clarifying limitations when importing databricks_sql_table [Fix] Populate partitions when reading databricks_sql_table Feb 13, 2025
@nkvuong nkvuong requested a review from alexott February 13, 2025 03:51
mgyucht
mgyucht reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A confusing API to integrate with. Overall I think the logic seems OK. Let's use the Go SDK service when we can rather than hardcording the endpoint: does the table in the SDK include the partition info?

@nkvuong nkvuong requested a review from mgyucht February 17, 2025 12:05
@alexott alexott enabled auto-merge February 26, 2025 04:30
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4486
  • Commit SHA: 2aecd62f92eebeebc2d2467e4e6a4018050c6feb

Checks will be approved automatically on success.

@alexott alexott added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit f6cbfa8 Feb 26, 2025
13 checks passed
@alexott alexott deleted the doc/sql_table_limitations branch February 26, 2025 15:51
tanmay-db added a commit that referenced this pull request Feb 26, 2025
@tanmay-db
[Release] Release v1.66.1
17100a0 
### New Features and Improvements

 * Add support for cluster logs delivery to UC Volumes ([#4492](#4492)).
 * Expose more attributes for `databricks_connection` resource ([#4502](#4502)).
 * add `databricks_dashboards` data source ([#4521](#4521)).

### Bug Fixes

 * Delete `databricks_sql_endpoint` that failed to start ([#4520](#4520)).
 * Fix filling of missing attributes in `databricks_quality_monitor` ([#4519](#4519)).
 * Mark `default_catalog_name` attribute in `databricks_metastore_assignment` as deprecated ([#4522](#4522)).
 * Only allow `authorized_paths` to be updated in the `options` field of `databricks_catalog` ([#4517](#4517)).
 * Populate `partitions` when reading `databricks_sql_table` ([#4486](#4486)).
 * Remove configuration drift when configuring `databricks_connection` to built-in Hive Metastore ([#4505](#4505)).

### Documentation

 * Improve documentation for databricks_cluster and databricks_clusters ([#4506](#4506)).
 * Small fix to docs for data source `databricks_cluster` ([#4510](#4510)).
 * mark `databricks_volume` and `databricks_credential` as GA ([#4524](#4524)).

### Internal Changes

 * Upgrade `staticcheck` to compatible with Go 1.24 ([#4507](#4507)).
 * Use InputGitAuthor when tagging a commit ([#4501](#4501)).
 * fix `TestUcAccDataSourceShares` flakiness ([#4526](#4526)).
 * switch `TestMwsAccWorkspacesTokenUpdate` to BYOVPC ([#4525](#4525)).

### Dependency Updates

 * Bump github.com/hashicorp/terraform-plugin-framework from 1.14.0 to 1.14.1 ([#4515](#4515)).
 * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.16.0 to 0.17.0 ([#4511](#4511)).
 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.36.0 to 2.36.1 ([#4512](#4512)).
 * Bump to 1.24.0 ([#4508](#4508)).

### Exporter

 * Explicitly abort execution via `panic` if list of users can't be fetched ([#4500](#4500)).
 * Fix matching on `workspace_path` and refactoring ([#4504](#4504)).
@tanmay-db tanmay-db mentioned this pull request Feb 26, 2025
Closed
deco-sdk-tagging bot added a commit that referenced this pull request Feb 26, 2025
@deco-sdk-tagging
[Release] Release v1.67.0
e156fb8 
## Release v1.67.0

### New Features and Improvements

 * Add support for cluster logs delivery to UC Volumes ([#4492](#4492)).
 * Expose more attributes for `databricks_connection` resource ([#4502](#4502)).
 * Add `databricks_dashboards` resource ([#4521](#4521))

### Bug Fixes

 * Populate `partitions` when reading `databricks_sql_table` ([#4486](#4486)).
 * Fix configuration drift when configuring `databricks_connection` to builtin Hive Metastore ([#4505](#4505)).
 * Only allow `authorized_paths` to be updated in the `options` field of `databricks_catalog` ([#4517](#4517)).
 * Mark `default_catalog_name` attribute in `databricks_metastore_assignment` as deprecated ([#4522](#4522))
 * Delete `databricks_sql_endpoint` that failed to start ([#4520](#4520))
 * Fix filling of missing attributes in `databricks_quality_monitor` ([#4519](#4519)).

### Documentation

 * Update `databricks_cluster` and `databricks_clusters` data source documentation ([#4506](#4506)).

### Exporter

 * Explicitly abort execution via `panic` if list of users can't be fetched ([#4500](#4500)).
 * Fix matching on `workspace_path` and refactoring ([#4504](#4504)).

### Internal Changes

 * Bump golang version to 1.24.0 ([#4508](#4508)).
@nkvuong nkvuong mentioned this pull request Feb 27, 2025
Merged
1 task
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
@nkvuong
[Fix] Revert partition read in databricks_sql_table (#4536)
ad0bd09 
## Changes
Revert #4486 to resolve #4535

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally

NO_CHANGELOG=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_sql_table resource import
3 participants
@nkvuong @alexott @mgyucht