Skip to content

Commit

Permalink
disable integration tests on forks
Browse files Browse the repository at this point in the history
Require pyspark dependencies only for tests and cli
  • Loading branch information
mwojtyczka committed Feb 4, 2025
1 parent 5252b7a commit 12b9e16
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ concurrency:

jobs:
integration:
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
# Only run this job for PRs from branches on the main repository and not from forks.
# Workflows triggered by PRs from forks don't have access to the tool environment.
if: github.event_name == 'pull_request' && !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork
environment: tool
runs-on: larger
steps:
Expand Down Expand Up @@ -55,7 +57,9 @@ jobs:
ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}

serverless_integration:
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
# Only run this job for PRs from branches on the main repository and not from forks.
# Workflows triggered by PRs from forks don't have access to the tool environment.
if: github.event_name == 'pull_request' && !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork
environment: tool
runs-on: larger
env:
Expand Down
1 change: 1 addition & 0 deletions labs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: dqx
description: Data Quality Framework for PySpark Workloads
install:
script: src/databricks/labs/dqx/installer/install.py
extras: cli
uninstall:
script: src/databricks/labs/dqx/installer/uninstall.py
entrypoint: src/databricks/labs/dqx/cli.py
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ classifiers = [
dependencies = ["databricks-labs-blueprint>=0.9.1,<0.10",
"databricks-sdk~=0.30",
"databricks-labs-lsql>=0.5,<0.15",
"pyspark~=3.5.0" # required by the CLI to work correctly
]

[project.optional-dependencies]
cli = ["pyspark~=3.5.0"]

[project.entry-points.databricks]
runtime = "databricks.labs.dqx.runtime:main"

Expand Down Expand Up @@ -70,6 +72,7 @@ dependencies = [
"types-PyYAML~=6.0.12",
"types-requests~=2.31.0",
"databricks-connect~=15.4",
"pyspark~=3.5.0",
]

python="3.10"
Expand Down

0 comments on commit 12b9e16

Please sign in to comment.