Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX-1182] protowhat update #146

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[CX-1182] protowhat update #146

wants to merge 12 commits into from

Conversation

hermansje
Copy link
Member

Ticket

Link to ticket: https://datacamp.atlassian.net/browse/CX-1182

What has been done

How to test

  • Run the tests on top of the protowhat branch

@hermansje hermansje requested a review from TimSangster January 14, 2020 15:50
@hermansje hermansje self-assigned this Jan 14, 2020
sqlwhat/sct_context.py Show resolved Hide resolved
sqlwhat/sct_context.py Show resolved Hide resolved
sqlwhat/test_exercise.py Show resolved Hide resolved
sqlwhat/test_exercise.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #146 into master will decrease coverage by 0.52%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   80.78%   80.26%   -0.53%     
==========================================
  Files           7        7              
  Lines         229      228       -1     
==========================================
- Hits          185      183       -2     
- Misses         44       45       +1
Impacted Files Coverage Δ
sqlwhat/sct_context.py 100% <100%> (ø)
sqlwhat/checks/__init__.py 100% <100%> (ø) ⬆️
sqlwhat/checks/has_funcs.py 100% <100%> (ø) ⬆️
sqlwhat/checks/check_funcs.py 61.32% <62.5%> (-0.72%) ⬇️
sqlwhat/test_exercise.py 94.11% <92.85%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8aecb...88ac7e1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants