Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use envir_prep for exercise checking #233

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

schloerke
Copy link

Fixes rstudio/learnr#202

The next release of learnr (v0.10.0) will provide a copy of the environment before the user executed their code envir_prep to the exercise checker function (ex: testwhat_learnr).

Using this environment, checking code will be able to find their setup code.

Disclaimers:

  • I have not tested this.
  • I do not know if I have broken run_until_fail.
  • I would believe this would work with learnr v0.9.2 and the next release of v0.10.0
  • Existing users should not have to alter their code to get the expected behavior

cc @matthew-brett @reuning

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   92.11%   92.11%   +<.01%     
==========================================
  Files          47       47              
  Lines        2586     2588       +2     
==========================================
+ Hits         2382     2384       +2     
  Misses        204      204
Impacted Files Coverage Δ
R/utils-learnr.R 0% <0%> (ø) ⬆️
R/test-exercise.R 88.37% <100%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f63f96...eba2090. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup chunks should be available to solutions
1 participant