Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subhankar] add max numeric metric #3

Merged
merged 1 commit into from
Jul 23, 2023
Merged

[Subhankar] add max numeric metric #3

merged 1 commit into from
Jul 23, 2023

Conversation

subhankarb
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: +13.67 🎉

Comparison is base (47db070) 59.74% compared to head (45d7e8d) 73.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
+ Coverage   59.74%   73.41%   +13.67%     
===========================================
  Files          13       13               
  Lines         308      316        +8     
===========================================
+ Hits          184      232       +48     
+ Misses        124       84       -40     
Impacted Files Coverage Δ
datachecks/core/metric/numeric_metric.py 82.14% <ø> (+28.57%) ⬆️
datachecks/core/datasource/base.py 85.36% <90.90%> (+27.03%) ⬆️
datachecks/core/datasource/opensearch.py 96.15% <100.00%> (+21.15%) ⬆️
datachecks/core/metric/base.py 89.85% <100.00%> (+19.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@subhankarb subhankarb merged commit 8cdfc8c into main Jul 23, 2023
3 of 4 checks passed
@subhankarb subhankarb deleted the max_metric branch July 23, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant