Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subhankar] add env variable support in configuration file #6

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

subhankarb
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 75.43% and project coverage change: -1.43 ⚠️

Comparison is base (2aac243) 81.76% compared to head (17a3fdc) 80.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   81.76%   80.34%   -1.43%     
==========================================
  Files          14       15       +1     
  Lines         362      407      +45     
==========================================
+ Hits          296      327      +31     
- Misses         66       80      +14     
Impacted Files Coverage Δ
datachecks/core/metric/freshness_metric.py 90.90% <ø> (ø)
datachecks/core/metric/manager.py 84.84% <25.00%> (-8.26%) ⬇️
datachecks/core/configuration/config_loader.py 77.08% <77.08%> (ø)
datachecks/core/configuration/configuration.py 93.61% <100.00%> (+0.28%) ⬆️
datachecks/core/datasource/base.py 84.31% <100.00%> (-2.13%) ⬇️
datachecks/core/metric/base.py 88.40% <100.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@subhankarb subhankarb merged commit 7513bb2 into main Jul 23, 2023
6 checks passed
@subhankarb subhankarb deleted the config_env_variable branch July 23, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant