Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading upper and lower legislative districts #10

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

rdmurphy
Copy link
Contributor

@rdmurphy rdmurphy commented Apr 3, 2019

👋

This adds support for downloading upper and lower state legislative districts as mentioned in #3.

I haven't actually smashed it against the doomsday device/download_everything call, but will give it a shot once I'm home! Quick tests of passing TX into AgeDownloader were successful.

@palewire
Copy link
Contributor

palewire commented Apr 3, 2019

Doomsday device is def. right. Pretty sure @ryanpitts thinks it's an abomination. An ad hoc CLI for downloading individual classes would be a good add separate from this.

@palewire
Copy link
Contributor

palewire commented Apr 3, 2019

Question. Does the Census API require you provide a state to this function, or could we download the entire country at once?

@palewire palewire merged commit 88cf711 into datadesk:master Apr 3, 2019
@rdmurphy
Copy link
Contributor Author

rdmurphy commented Apr 3, 2019

@palewire Hah, see this was already merged, but I both checked 1) if download_everything worked (it did) and 2) you cannot download the entire country all at once for legislative districts, it expects a state.

@palewire
Copy link
Contributor

palewire commented Apr 3, 2019

Thanks. You're out with the new version on PyPI. I've also added a new CLI interface that's now in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants