This repository has been archived by the owner on May 17, 2024. It is now read-only.
Relax the restrictions of dependencies versions: >= instead of ^ and = #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a library, so it must allow newer versions of dependencies in the virtualenv of the app, it should not restrict them to specific versions.
anatoly-scherbakov
approved these changes
Feb 19, 2024
nolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #775.
The best approach for libraries is to assume the newer major versions of dependencies are backwards-compatible to the extent that we user them, breaking only in rare edge cases, which we likely do not use.
If it breaks, the app developers can put additional restrictions on their side in their virtualenvs. It is NOT the job of a library to restrict the dependencies from the upper side.
Only the lower restrictions should be set — to the minimum version supporting specific functionality that we use. Again, as lower as possible — to let the app developers space for maneuvering within their virtualenvs and whatever legacy code they have, as long as it does not break our code.