Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sqllogictest integration #12

Conversation

jatin510
Copy link
Contributor

No description provided.

@jatin510
Copy link
Contributor Author

   --> tests/sqllogictest/sqllogictest.rs:93:48
    |
93  |       let mut runner = sqllogictest::Runner::new(|| async {
    |  ______________________-------------------------_^
    | |                      |
    | |                      required by a bound introduced by this call
94  | |         Ok(TestExecution::new(
95  | |             test_ctx.session_ctx().clone(),
96  | |             relative_path.clone(),
97  | |         ))
98  | |     });
    _____^ the trait `DB` is not implemented for `impl futures::Future<Output = TestExecution>`, which is required by `{closure@tests/sqllogictest/sqllogictest.rs:93:48: 93:50}: MakeConnection`

getting this error,
But I am using AsyncDB implementation
Any idea how to solve this issue

@alamb
Copy link
Contributor

alamb commented Oct 29, 2024

   --> tests/sqllogictest/sqllogictest.rs:93:48
    |
93  |       let mut runner = sqllogictest::Runner::new(|| async {
    |  ______________________-------------------------_^
    | |                      |
    | |                      required by a bound introduced by this call
94  | |         Ok(TestExecution::new(
95  | |             test_ctx.session_ctx().clone(),
96  | |             relative_path.clone(),
97  | |         ))
98  | |     });
    _____^ the trait `DB` is not implemented for `impl futures::Future<Output = TestExecution>`, which is required by `{closure@tests/sqllogictest/sqllogictest.rs:93:48: 93:50}: MakeConnection`

getting this error, But I am using AsyncDB implementation Any idea how to solve this issue

That error looks like you are passing a future. I think you need to pass an instance of TestExecution

Instead of

    let mut runner = sqllogictest::Runner::new(|| async {
        Ok(TestExecution::new(
            test_ctx.session_ctx().clone(),
            relative_path.clone(),
        ))
    });

Does this work?

    let mut runner = sqllogictest::Runner::new(TestExecution::new(
            test_ctx.session_ctx().clone(),
            relative_path.clone(),
        ))
    );

Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 30 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 29, 2024
@github-actions github-actions bot closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants