Skip to content

Commit

Permalink
Fix: bug fix for empty key values pair in elastic search mapping
Browse files Browse the repository at this point in the history
  • Loading branch information
milindgupta committed Jul 26, 2024
1 parent 56bb4c8 commit 1d281b7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ public void setSearchableValue(
.forEach(
fieldValue -> {
String[] keyValues = fieldValue.toString().split("=");
String key = keyValues[0];
String value = keyValues[1];
String key = keyValues[0], value = "";
if (keyValues.length > 1) {
value = keyValues[1];
}
dictDoc.put(key, value);
});
searchDocument.set(fieldName, dictDoc);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ public static TestEntityInfo getTestEntityInfo(Urn urn) {
"value1",
"key2",
"value2",
"key3",
"",
"shortValue",
"123",
"longValue",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public void testTransform() throws IOException {
assertEquals(parsedJson.get("feature2").asInt(), 1);
JsonNode browsePathV2 = (JsonNode) parsedJson.get("browsePathV2");
assertEquals(browsePathV2.asText(), "␟levelOne␟levelTwo");
assertEquals(parsedJson.get("esObjectField").get("key3").asText(), "");
}

@Test
Expand Down

0 comments on commit 1d281b7

Please sign in to comment.