Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history
  • Loading branch information
@eboneil
eboneil committed Aug 24, 2023
1 parent a4cb81c commit 34fdc1b
Showing 1 changed file with 21 additions and 8 deletions.
29 changes: 21 additions & 8 deletions ...est/java/com/linkedin/metadata/search/elasticsearch/fixtures/ElasticSearchGoldenTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.context.annotation.Import;
import org.springframework.test.context.testng.AbstractTestNGSpringContextTests;
import org.testng.annotations.Ignore;
import org.testng.annotations.Test;

import java.util.List;
Expand Down Expand Up @@ -57,13 +58,15 @@ public void testNameMatchPetProfiles() {
SearchResult searchResult = searchAcrossCustomEntities(searchService, "pet profiles", SEARCHABLE_LONGTAIL_ENTITIES);
assertTrue(searchResult.getEntities().size() >= 2);
Urn firstResultUrn = searchResult.getEntities().get(0).getEntity();
System.out.println("firstResultUrn: " + firstResultUrn);
Urn secondResultUrn = searchResult.getEntities().get(1).getEntity();
System.out.println("secondResultUrn: " + secondResultUrn);

assertTrue(firstResultUrn.toString().contains("pet_profiles"));
assertTrue(secondResultUrn.toString().contains("pet_profiles"));
}

@Test
@Test
public void testNameMatchPetProfile() {
/*
Searching for "pet profile" should return "pet_profiles" as the first 2 search results
Expand All @@ -72,7 +75,9 @@ public void testNameMatchPetProfile() {
SearchResult searchResult = searchAcrossEntities(searchService, "pet profile", SEARCHABLE_LONGTAIL_ENTITIES);
assertTrue(searchResult.getEntities().size() >= 2);
Urn firstResultUrn = searchResult.getEntities().get(0).getEntity();
System.out.println("firstResultUrn: " + firstResultUrn);
Urn secondResultUrn = searchResult.getEntities().get(1).getEntity();
System.out.println("secondResultUrn: " + secondResultUrn);

assertTrue(firstResultUrn.toString().contains("pet_profiles"));
assertTrue(secondResultUrn.toString().contains("pet_profiles"));
Expand All @@ -86,17 +91,16 @@ public void testGlossaryTerms() {
*/
assertNotNull(searchService);
SearchResult searchResult = searchAcrossEntities(searchService, "ReturnRate", SEARCHABLE_LONGTAIL_ENTITIES);
System.out.println("GLOSSARY TERMS RESULTS: " + searchResult);
SearchEntityArray entities = searchResult.getEntities();
assertTrue(searchResult.getEntities().size() >= 4);
assertTrue(searchResult.getEntities().size() >= 2);
MatchedFieldArray firstResultMatchedFields = entities.get(0).getMatchedFields();
System.out.println("firstResultMatchedFields: " + firstResultMatchedFields);
MatchedFieldArray secondResultMatchedFields = entities.get(1).getMatchedFields();
MatchedFieldArray thirdResultMatchedFields = entities.get(2).getMatchedFields();
MatchedFieldArray fourthResultMatchedFields = entities.get(3).getMatchedFields();
System.out.println("secondResultMatchedFields: " + secondResultMatchedFields);

assertTrue(firstResultMatchedFields.toString().contains("ReturnRate"));
assertTrue(secondResultMatchedFields.toString().contains("ReturnRate"));
assertTrue(thirdResultMatchedFields.toString().contains("ReturnRate"));
assertTrue(fourthResultMatchedFields.toString().contains("ReturnRate"));
}

@Test
Expand All @@ -109,7 +113,9 @@ public void testNameMatchPartiallyQualified() {
SearchResult searchResult = searchAcrossEntities(searchService, "analytics.pet_details", SEARCHABLE_LONGTAIL_ENTITIES);
assertTrue(searchResult.getEntities().size() >= 2);
Urn firstResultUrn = searchResult.getEntities().get(0).getEntity();
System.out.println("firstResultUrn: " + firstResultUrn);
Urn secondResultUrn = searchResult.getEntities().get(1).getEntity();
System.out.println("secondResultUrn: " + secondResultUrn);

assertTrue(firstResultUrn.toString().contains("snowflake,long_tail_companions.analytics.pet_details"));
assertTrue(secondResultUrn.toString().contains("dbt,long_tail_companions.analytics.pet_details"));
Expand All @@ -119,20 +125,24 @@ public void testNameMatchPartiallyQualified() {
public void testNameMatchCollaborativeActionitems() {
/*
Searching for "collaborative actionitems" should return "collaborative_actionitems" as the first search
result, followed by "collaborative_actionitems_old"
result, followed by anything else that includes "collaborative_actionitems"
*/
assertNotNull(searchService);
SearchResult searchResult = searchAcrossEntities(searchService, "collaborative actionitems", SEARCHABLE_LONGTAIL_ENTITIES);
assertTrue(searchResult.getEntities().size() >= 2);
Urn firstResultUrn = searchResult.getEntities().get(0).getEntity();
System.out.println("firstResultUrn: " + firstResultUrn);
Urn secondResultUrn = searchResult.getEntities().get(1).getEntity();
System.out.println("secondResultUrn: " + secondResultUrn);

// Checks that the table name is not suffixed with anything
assertTrue(firstResultUrn.toString().contains("collaborative_actionitems,"));
assertTrue(secondResultUrn.toString().contains("collaborative_actionitems_old"));
assertTrue(secondResultUrn.toString().contains("collaborative_actionitems"));

Double firstResultScore = searchResult.getEntities().get(0).getScore();
System.out.println("firstResultScore: " + firstResultScore);
Double secondResultScore = searchResult.getEntities().get(1).getScore();
System.out.println("secondResultScore: " + secondResultScore);

// Checks that the scores aren't tied so that we are matching on table name more than column name
assertTrue(firstResultScore > secondResultScore);
Expand All @@ -148,12 +158,15 @@ public void testNameMatchCustomerOrders() {
SearchResult searchResult = searchAcrossEntities(searchService, "customer orders", SEARCHABLE_LONGTAIL_ENTITIES);
assertTrue(searchResult.getEntities().size() >= 2);
Urn firstResultUrn = searchResult.getEntities().get(0).getEntity();
System.out.println("firstResultUrn: " + firstResultUrn);

// Checks that the table name is not suffixed with anything
assertTrue(firstResultUrn.toString().contains("customer_orders,"));

Double firstResultScore = searchResult.getEntities().get(0).getScore();
System.out.println("firstResultScore: " + firstResultScore);
Double secondResultScore = searchResult.getEntities().get(1).getScore();
System.out.println("secondResultScore: " + secondResultScore);

// Checks that the scores aren't tied so that we are matching on table name more than column name
assertTrue(firstResultScore > secondResultScore);
Expand Down

0 comments on commit 34fdc1b

Please sign in to comment.