Skip to content

Commit

Permalink
fix default
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanHolstien committed Nov 17, 2023
1 parent 9b7d78d commit 4cd00ab
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions metadata-ingestion/src/datahub/cli/quickstart_versioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def fetch_quickstart_config(cls) -> "QuickstartVersionMappingConfig":
return config

def get_quickstart_execution_plan(
self, requested_version: Optional[str]
self, requested_version: Optional[str],
) -> QuickstartExecutionPlan:
"""
From the requested version and stable flag, returns the execution plan for the quickstart.
Expand All @@ -115,11 +115,14 @@ def get_quickstart_execution_plan(
requested_version = "default"
composefile_git_ref = requested_version
docker_tag = requested_version
mysql_tag = requested_version
# Default to 5.7 if not specified in version map
mysql_tag = "5.7"
result = self.quickstart_version_map.get(
requested_version,
QuickstartExecutionPlan(
composefile_git_ref=composefile_git_ref, docker_tag=docker_tag, mysql_tag=mysql_tag
composefile_git_ref=composefile_git_ref,
docker_tag=docker_tag,
mysql_tag=mysql_tag
),
)
# new CLI version is downloading the composefile corresponding to the requested version
Expand Down

0 comments on commit 4cd00ab

Please sign in to comment.