Adjusting the data for incidents

datahub-project · Jan 26, 2024 · 4e50bc9 · 4e50bc9
1 parent fa62205
commit 4e50bc9
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 6 deletions.
diff --git a/smoke-test/tests/cypress/cypress/e2e/mutations/dataset_health.js b/smoke-test/tests/cypress/cypress/e2e/mutations/dataset_health.js
@@ -12,8 +12,6 @@ describe("dataset health test", () => {
         cy.waitTextVisible("Assertions 1 of 1 assertions are failing");
         cy.get('[data-testid="assertions-details"]').click();
         // cy.clickOptionWithText("details");
-        cy.waitTextVisible("All assertions are failing");
-        cy.clickOptionWithText("External");
-        cy.waitTextVisible("Failed");
-        });
+        cy.waitTextVisible("1 failed assertions");
+    });
 });
diff --git a/smoke-test/tests/cypress/data.json b/smoke-test/tests/cypress/data.json
@@ -2012,6 +2012,32 @@
     },
     "systemMetadata": null
   },
+  {
+    "auditHeader": null,
+    "entityType": "assertion",
+    "entityUrn": "urn:li:assertion:358c683782c93c2fc2bd4bdd4fdb0153",
+    "entityKeyAspect": null,
+    "changeType": "UPSERT",
+    "aspectName": "assertionInfo",
+    "aspect": {
+      "value": "{\"customProperties\": {\"expectation_suite_name\": \"test_suite\"}, \"type\": \"DATASET\", \"datasetAssertion\": {\"dataset\": \"urn:li:dataset:(urn:li:dataPlatform:hdfs,SampleCypressHdfsDataset,PROD)\", \"scope\": \"DATASET_COLUMN\", \"fields\": [\"urn:li:schemaField:(urn:li:dataset:(urn:li:dataPlatform:hive,SampleHiveDataset,PROD),field_foo)\"], \"aggregation\": \"IDENTITY\", \"operator\": \"EQUAL_TO\", \"parameters\": {\"value\": {\"value\": \"true\", \"type\": \"UNKNOWN\"} }, \"nativeType\": \"expect_column_values_to_equal\", \"nativeParameters\": {\"column\": \"field_foo\", \"value\": \"true\"}}}",
+      "contentType": "application/json"
+    },
+    "systemMetadata": null
+  },
+  {
+    "auditHeader": null,
+    "entityType": "assertion",
+    "entityUrn": "urn:li:assertion:358c683782c93c2fc2bd4bdd4fdb0153",
+    "entityKeyAspect": null,
+    "changeType": "UPSERT",
+    "aspectName": "assertionRunEvent",
+    "aspect": {
+      "value": "{\"timestampMillis\": 1675155843000, \"partitionSpec\": {\"type\": \"PARTITION\", \"partition\": \"{\\\"category\\\": \\\"catA\\\"}\"}, \"runId\": \"2021-12-28T12:00:00Z\", \"assertionUrn\": \"urn:li:assertion:358c683782c93c2fc2bd4bdd4fdb0153\", \"asserteeUrn\": \"urn:li:dataset:(urn:li:dataPlatform:hdfs,SampleCypressHdfsDataset,PROD)\", \"batchSpec\": {\"customProperties\": {\"data_asset_name\": \"data__foo1__asset\", \"datasource_name\": \"my_hive_datasource\"}, \"nativeBatchId\": \"c8f12129f2e57412eee5fb8656154d05\", \"limit\": 10}, \"status\": \"COMPLETE\", \"result\": {\"type\": \"FAILURE\", \"nativeResults\": {}}}",
+      "contentType": "application/json"
+    },
+    "systemMetadata": null
+  },
   {
     "auditHeader": null,
     "entityType": "incident",

diff --git a/smoke-test/tests/incidents/data.json b/smoke-test/tests/incidents/data.json
@@ -147,7 +147,7 @@
     "changeType":"UPSERT",
     "aspectName":"incidentInfo",
     "aspect":{
-      "value":"{\"type\": \"OPERATIONAL\", \"title\": \"test title\", \"description\": \"test description\", \"entities\": [\"urn:li:dataset:(urn:li:dataPlatform:kafka,incidents-sample-dataset,PROD)\"], \"status\": { \"state\": \"ACTIVE\", \"lastUpdated\": { \"time\": 0, \"actor\": \"urn:li:corpuser:admin\" } }, \"source\": { \"type\": \"ASSERTION_FAILURE\", \"sourceUrn\": \"urn:li:assertion:assertion-test\"}, \"created\": { \"time\": 0, \"actor\": \"urn:li:corpuser:admin\" } }",
+      "value":"{\"type\": \"OPERATIONAL\", \"title\": \"test title\", \"description\": \"test description\", \"entities\": [\"urn:li:dataset:(urn:li:dataPlatform:kafka,incidents-sample-dataset,PROD)\"], \"status\": { \"state\": \"ACTIVE\", \"lastUpdated\": { \"time\": 0, \"actor\": \"urn:li:corpuser:admin\" } }, \"source\": { \"type\": \"MANUAL\" }, \"created\": { \"time\": 0, \"actor\": \"urn:li:corpuser:admin\" } }",
       "contentType":"application/json"
     },
     "systemMetadata":null

diff --git a/smoke-test/tests/incidents/incidents_test.py b/smoke-test/tests/incidents/incidents_test.py
@@ -105,7 +105,7 @@ def test_list_dataset_incidents(frontend_session):
                     "lastUpdated": {"time": 0, "actor": "urn:li:corpuser:admin"},
                 },
                 "source": {
-                    "type": "ASSERTION_FAILURE",
+                    "type": "MANUAL",
                     "source": {
                         "urn": "urn:li:assertion:assertion-test",
                         "info": {"type": "DATASET"},