Skip to content

Commit

Permalink
fix CI after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
anshbansal committed Jan 30, 2024
1 parent 52da483 commit 75adfc9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
6 changes: 0 additions & 6 deletions smoke-test/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,12 @@ slack-sdk==3.18.1
aiohttp
joblib
pytest-xdist
<<<<<<< HEAD
networkx
=======
# libaries for linting below this
>>>>>>> 3989f4d73d8 (more linting)
black==23.7.0
isort==5.12.0
mypy==1.5.1
ruff==0.0.287
<<<<<<< HEAD
=======
# stub version are copied from metadata-ingestion/setup.py and that should be the source of truth
types-requests>=2.28.11.6,<=2.31.0.3
types-PyYAML
>>>>>>> 3989f4d73d8 (more linting)
5 changes: 4 additions & 1 deletion smoke-test/tests/lineage/test_lineage.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
from datahub.utilities.urns.dataset_urn import DatasetUrn
from datahub.utilities.urns.urn import Urn
from pydantic import BaseModel, validator

from tests.utils import ingest_file_via_rest, wait_for_writes_to_sync

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -85,7 +86,6 @@ def ingest_tableau_cll_via_rest(wait_for_healthchecks) -> None:
ingest_file_via_rest(
"tests/lineage/tableau_cll_mcps.json",
)
yield


def search_across_lineage(
Expand Down Expand Up @@ -499,6 +499,7 @@ def get_lineage_mcps(self) -> Iterable[MetadataChangeProposalWrapper]:
def get_lineage_mcps_for_hop(
self, hop_index: int
) -> Iterable[MetadataChangeProposalWrapper]:
assert self.expectations is not None
if self.lineage_style == Scenario.LineageStyle.DATASET_JOB_DATASET:
fine_grained_lineage = FineGrainedLineage(
upstreamType=FineGrainedLineageUpstreamType.FIELD_SET,
Expand Down Expand Up @@ -723,10 +724,12 @@ def cleanup(self, delete_agent: DeleteAgent) -> None:
delete_agent.delete_entity(urn)

def generate_expectation(self, query: ImpactQuery) -> LineageExpectation:
assert self.expectations is not None
return self.expectations.generate_query_expectation_pairs(query)

def test_expectation(self, graph: DataHubGraph) -> bool:
print("Testing expectation...")
assert self.expectations is not None
try:
for hop_index in range(self.num_hops):
for dataset_urn in self.get_upstream_dataset_urns(hop_index):
Expand Down

0 comments on commit 75adfc9

Please sign in to comment.