add back ingest_data_platform_instance_aspect

datahub-project · Oct 5, 2023 · af0622c · af0622c
1 parent 3cbce63
commit af0622c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/unity/config.py b/metadata-ingestion/src/datahub/ingestion/source/unity/config.py
@@ -114,8 +114,12 @@ class UnityCatalogSourceConfig(
         ),
     )
 
-    _ingest_data_platform_instance_aspect_removed = pydantic_removed_field(
-        "ingest_data_platform_instance_aspect"
+    ingest_data_platform_instance_aspect: Optional[bool] = pydantic.Field(
+        default=False,
+        description=(
+            "Option to enable/disable ingestion of the data platform instance aspect."
+            " The default data platform instance id for a dataset is workspace_name"
+        ),
     )
 
     _only_ingest_assigned_metastore_removed = pydantic_removed_field(

diff --git a/metadata-ingestion/src/datahub/ingestion/source/unity/source.py b/metadata-ingestion/src/datahub/ingestion/source/unity/source.py
@@ -672,15 +672,19 @@ def _create_table_ownership_aspect(self, table: Table) -> Optional[OwnershipClas
             )
         return None
 
-    def _create_data_platform_instance_aspect(self) -> DataPlatformInstanceClass:
-        return DataPlatformInstanceClass(
-            platform=make_data_platform_urn(self.platform),
-            instance=make_dataplatform_instance_urn(
-                self.platform, self.platform_instance_name
+    def _create_data_platform_instance_aspect(
+        self,
+    ) -> Optional[DataPlatformInstanceClass]:
+        if self.config.ingest_data_platform_instance_aspect:
+            return DataPlatformInstanceClass(
+                platform=make_data_platform_urn(self.platform),
+                instance=make_dataplatform_instance_urn(
+                    self.platform, self.platform_instance_name
+                )
+                if self.platform_instance_name
+                else None,
             )
-            if self.platform_instance_name
-            else None,
-        )
+        return None
 
     def _create_table_sub_type_aspect(self, table: Table) -> SubTypesClass:
         return SubTypesClass(