Skip to content

Commit

Permalink
Rebase on the latest, fix spotless issues
Browse files Browse the repository at this point in the history
  • Loading branch information
John Joyce committed Jan 24, 2024
1 parent b0c3714 commit bdea3b9
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1205,8 +1205,8 @@ private void configureMutationResolvers(final RuntimeWiring.Builder builder) {
"verifyForm", new VerifyFormResolver(this.formService, this.groupService))
.dataFetcher("raiseIncident", new RaiseIncidentResolver(this.entityClient))
.dataFetcher(
"updateIncidentStatus",
new UpdateIncidentStatusResolver(this.entityClient, this.entityService)));
"updateIncidentStatus",
new UpdateIncidentStatusResolver(this.entityClient, this.entityService)));
}

private void configureGenericEntityResolvers(final RuntimeWiring.Builder builder) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,8 @@ public class ESUtils {
};

// TODO - This has been expanded for has* in another branch
public static final Set<String> BOOLEAN_FIELDS = ImmutableSet.of(
"removed",
"hasActiveIncidents",
"hasResolvedIncidents");
public static final Set<String> BOOLEAN_FIELDS =
ImmutableSet.of("removed", "hasActiveIncidents", "hasResolvedIncidents");

/*
* Refer to https://www.elastic.co/guide/en/elasticsearch/reference/current/regexp-syntax.html for list of reserved
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void testHooks() {
assertEquals(
1,
metadataChangeLogProcessor.getHooks().stream()
.filter(hook -> hook instanceof IncidentsSummaryHook)
.count());
.filter(hook -> hook instanceof IncidentsSummaryHook)
.count());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import com.datahub.authentication.Authentication;
import com.linkedin.entity.client.EntityClient;
import com.linkedin.gms.factory.auth.SystemAuthenticationFactory;
import com.linkedin.gms.factory.entity.RestliEntityClientFactory;
import com.linkedin.gms.factory.entityclient.RestliEntityClientFactory;
import com.linkedin.metadata.service.IncidentService;
import com.linkedin.metadata.spring.YamlPropertySourceFactory;
import javax.annotation.Nonnull;
Expand All @@ -20,7 +20,7 @@
@Import({SystemAuthenticationFactory.class, RestliEntityClientFactory.class})
public class IncidentServiceFactory {
@Autowired
@Qualifier("restliEntityClient")
@Qualifier("entityClient")
private EntityClient _entityClient;

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,10 @@ public class PoliciesConfig {
"The ability to report or edit operations information about an entity.");

public static final Privilege EDIT_ENTITY_INCIDENTS_PRIVILEGE =
Privilege.of(
"EDIT_ENTITY_INCIDENTS",
"Edit Incidents",
"The ability to create and remove incidents for an entity.");
Privilege.of(
"EDIT_ENTITY_INCIDENTS",
"Edit Incidents",
"The ability to create and remove incidents for an entity.");

public static final Privilege EDIT_ENTITY_PRIVILEGE =
Privilege.of(
Expand Down

0 comments on commit bdea3b9

Please sign in to comment.