fix(sql-parser): convert platform instance to lowercase when building…

… table urns (#9181)

metadata-ingestion/src/datahub/utilities/sqlglot_lineage.py

@@ -360,8 +360,12 @@ def get_urn_for_table(self, table: _TableName, lower: bool = False) -> str:
         table_name = ".".join(
             filter(None, [table.database, table.db_schema, table.table])
         )
+
+        platform_instance = self.platform_instance
+
         if lower:
             table_name = table_name.lower()
+            platform_instance = platform_instance.lower() if platform_instance else None
 
         if self.platform == "bigquery":
             # Normalize shard numbers and other BigQuery weirdness.
@@ -372,7 +376,7 @@ def get_urn_for_table(self, table: _TableName, lower: bool = False) -> str:
 
         urn = make_dataset_urn_with_platform_instance(
             platform=self.platform,
-            platform_instance=self.platform_instance,
+            platform_instance=platform_instance,
             env=self.env,
             name=table_name,
         )

metadata-ingestion/tests/unit/sql_parsing/test_schemaresolver.py

@@ -0,0 +1,33 @@
+from datahub.utilities.sqlglot_lineage import SchemaResolver, _TableName
+
+
+def test_get_urn_for_table_lowercase():
+    schema_resolver = SchemaResolver(
+        platform="mssql",
+        platform_instance="Uppercased-Instance",
+        env="PROD",
+        graph=None,
+    )
+
+    table = _TableName(database="Database", db_schema="DataSet", table="Table")
+
+    assert (
+        schema_resolver.get_urn_for_table(table=table, lower=True)
+        == "urn:li:dataset:(urn:li:dataPlatform:mssql,uppercased-instance.database.dataset.table,PROD)"
+    )
+
+
+def test_get_urn_for_table_not_lower_should_keep_capital_letters():
+    schema_resolver = SchemaResolver(
+        platform="mssql",
+        platform_instance="Uppercased-Instance",
+        env="PROD",
+        graph=None,
+    )
+
+    table = _TableName(database="Database", db_schema="DataSet", table="Table")
+
+    assert (
+        schema_resolver.get_urn_for_table(table=table, lower=False)
+        == "urn:li:dataset:(urn:li:dataPlatform:mssql,Uppercased-Instance.Database.DataSet.Table,PROD)"
+    )