feat(ingestion/tableau) Ingest tags from datasource (#9730)

Co-authored-by: Harshal Sheth <[email protected]>
datahub-project · Jan 30, 2024 · d1604b3 · d1604b3
1 parent 1d06d38
commit d1604b3
Show file tree

Hide file tree

Showing 10 changed files with 14,469 additions and 4,063 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau.py b/metadata-ingestion/src/datahub/ingestion/source/tableau.py
@@ -1743,8 +1743,15 @@ def emit_datasource(
             aspects=[self.get_data_platform_instance()],
         )
 
-        # Browse path
+        # Tags
+        if datasource_info:
+            tags = self.get_tags(datasource_info)
+            if tags:
+                dataset_snapshot.aspects.append(
+                    builder.make_global_tag_aspect_with_tag_list(tags)
+                )
 
+        # Browse path
         if browse_path and is_embedded_ds and workbook and workbook.get(c.NAME):
             browse_path = (
                 f"{browse_path}/{workbook[c.NAME].replace('/', REPLACE_SLASH_CHAR)}"

diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
@@ -399,6 +399,9 @@ class MetadataQueryException(Exception):
     description
     uri
     projectName
+    tags {
+        name
+    }
 }
         """
 

diff --git a/metadata-ingestion/tests/integration/tableau/setup/publishedDatasourcesConnection_all.json b/metadata-ingestion/tests/integration/tableau/setup/publishedDatasourcesConnection_all.json
@@ -250,7 +250,12 @@
                     },
                     "description": "description for test publish datasource",
                     "uri": "sites/4989/datasources/155429",
-                    "projectName": "default"
+                    "projectName": "default",
+                    "tags": [
+                        {
+                            "name": "tag on published datasource"
+                        }
+                    ]
                 },
                 {
                     "__typename": "PublishedDatasource",