Skip to content

Commit

Permalink
Merge branch 'master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
jayasimhankv authored Oct 3, 2023
2 parents a83ef8c + 0a5e7d1 commit d6813c6
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ export default function EmbeddedProfile<T>({ urn, entityType, getOverridePropert
return <NonExistentEntityPage />;
}

const readOnly = false;

return (
<EntityContext.Provider
value={{
Expand All @@ -80,15 +82,15 @@ export default function EmbeddedProfile<T>({ urn, entityType, getOverridePropert
<StyledDivider />
<UpstreamHealth />
<StyledDivider />
<SidebarAboutSection readOnly />
<SidebarAboutSection readOnly={readOnly} />
<StyledDivider />
<SidebarOwnerSection readOnly />
<SidebarOwnerSection readOnly={readOnly} />
<StyledDivider />
<SidebarTagsSection readOnly properties={{ hasTags: true, hasTerms: true }} />
<SidebarTagsSection readOnly={readOnly} properties={{ hasTags: true, hasTerms: true }} />
<StyledDivider />
<SidebarDomainSection readOnly />
<SidebarDomainSection readOnly={readOnly} />
<StyledDivider />
<DataProductSection readOnly />
<DataProductSection readOnly={readOnly} />
</>
)}
</EntityContext.Provider>
Expand Down
2 changes: 1 addition & 1 deletion docs/act-on-metadata/impact-analysis.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Follow these simple steps to understand the full dependency chain of your data e
<img width="70%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/impact-analysis-filter-dependencies.png"/>
</p>

4. Slice and dice the result list by Entity Type, Platfrom, Owner, and more to isolate the relevant dependencies
4. Slice and dice the result list by Entity Type, Platform, Owner, and more to isolate the relevant dependencies

<p align="center">
<img width="70%" src="https://raw.githubusercontent.com/datahub-project/static-assets/main/imgs/impact-analysis-apply-filters.png"/>
Expand Down
2 changes: 1 addition & 1 deletion docs/ownership/ownership-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import TabItem from '@theme/TabItem';
<FeatureAvailability/>

**🤝 Version compatibility**
> Open Source DataHub: **0.10.3** | Acryl: **0.2.8**
> Open Source DataHub: **0.10.4** | Acryl: **0.2.8**
## What are Custom Ownership Types?
Custom Ownership Types are an improvement on the way to establish ownership relationships between users and the data assets they manage within DataHub.
Expand Down
19 changes: 13 additions & 6 deletions metadata-ingestion/examples/ownership/ownership_type.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
{
"urn": "urn:li:ownershipType:architect",
"info": {
"name": "Architect",
"description": "Technical person responsible for the asset"
[
{
"auditHeader":null,
"entityType":"ownershipType",
"entityUrn": "urn:li:ownershipType:architect",
"changeType":"UPSERT",
"aspectName":"ownershipTypeInfo",
"aspect":{
"value":"{\"name\": \"Architect\", \"description\": \"Technical person responsible for the asset\", \"created\": {\"time\": 1674291843000, \"actor\": \"urn:li:corpuser:jdoe\", \"impersonator\": null},\n\"lastModified\": {\"time\": 1674291843000, \"actor\": \"urn:li:corpuser:jdoe\", \"impersonator\": null}}",
"contentType":"application/json"
},
"systemMetadata":null
}
}
]
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/graph/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ def get_related_entities(
url=relationship_endpoint,
params={
"urn": entity_urn,
"direction": direction,
"direction": direction.value,
"relationshipTypes": relationship_types,
"start": start,
},
Expand Down

0 comments on commit d6813c6

Please sign in to comment.