fix(ingest/redshift): add path_spec support for copy command

[treff7es]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features

  • Enhanced lineage reporting functionality with new metrics for S3 path specifications.
  • Introduced improved error handling for lineage processing, ensuring smoother operations.

• Bug Fixes

  • Resolved issues with lineage path mismatches, allowing for better tracking and reporting.

• Documentation

  • Updated documentation to reflect new attributes and metrics in lineage processing.

[hsheth2]

@treff7es looks like there's merge conflicts on this one

[coderabbitai]

Walkthrough

The updates enhance the lineage reporting capabilities of the Redshift ingestion process by implementing better error handling and detailed metrics tracking. Key improvements include refined logic for handling S3 paths and the introduction of counters to monitor path specification matches and mismatches. These changes bolster the overall robustness and clarity of the data handling, ensuring more accurate lineage processing and reporting.

Changes

Files	Change Summary
.../lineage.py	Enhanced lineage reporting with new counters for S3 path specification matches and mismatches. Improved error handling in _get_sources method.
.../report.py	Introduced new attributes in RedshiftReport for tracking lineage processing metrics, including S3 path specification mismatches.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Lineage
    participant Report

    User->>Lineage: Request lineage data
    Lineage->>Lineage: Validate S3 path
    alt Path matches
        Lineage->>Lineage: Increment match counter
    else Path mismatch
        Lineage->>Lineage: Increment mismatch counter
    end
    Lineage->>Report: Update report with metrics
    Report->>User: Return lineage report

Loading

🐰 In the fields where data flows,
A rabbit hops where the lineage grows.
With matches counted and errors caught,
We track the paths that we have sought.
Hooray for the changes, both big and small,
In the world of data, we’ll conquer it all! 🌱

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 20574cf and 4d9b871.

Files selected for processing (2)

• metadata-ingestion/src/datahub/ingestion/source/redshift/lineage.py (3 hunks)
• metadata-ingestion/src/datahub/ingestion/source/redshift/report.py (3 hunks)

Additional comments not posted (5)

metadata-ingestion/src/datahub/ingestion/source/redshift/report.py (2)

40-40: LGTM!

The addition of s3_lineage_path_spec_mismatch with LossyList is appropriate for tracking S3 lineage path mismatches.

---

50-52: LGTM!

The introduction of num_lineage_processed_temp_tables, num_s3_lineage_path_spec_mismatch, and num_s3_lineage_path_spec_match enhances the tracking of lineage processing and S3 path specifications.

metadata-ingestion/src/datahub/ingestion/source/redshift/lineage.py (3)

272-279: LGTM!

The updates to _get_s3_path improve the tracking of path specification matches and mismatches, enhancing lineage reporting.

---

381-396: LGTM!

The updates to _get_sources improve error handling and ensure proper incrementing of the num_lineage_dropped_not_support_copy_path counter.

---

572-572: LGTM!

The update to _get_target_lineage ensures proper incrementing of the num_lineage_dropped_not_support_copy_path counter.

[hsheth2]

@treff7es CI is failing - seems like a small thing