Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate great-expectations action package #11096

Merged
merged 14 commits into from
Aug 21, 2024

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Aug 5, 2024

Helps with #8115

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Aug 5, 2024
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a bunch of small cleanup things

metadata-ingestion-modules/gx-plugin/setup.py Outdated Show resolved Hide resolved
metadata-ingestion-modules/gx-plugin/setup.py Show resolved Hide resolved
metadata-ingestion-modules/gx-plugin/setup.py Show resolved Hide resolved
uses: actions/upload-artifact@v3
with:
name: Event File
path: ${{ github.event_path }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this job is necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this job is present in all github workflows including metadata-ingestion , airflow, dagster. Not quite sure what's its purpose, though. I don't recall using this artifact for any purpose.

.github/workflows/gx-plugin.yml Show resolved Hide resolved
metadata-ingestion-modules/gx-plugin/build.gradle Outdated Show resolved Hide resolved
metadata-ingestion-modules/gx-plugin/build.gradle Outdated Show resolved Hide resolved
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 15, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Aug 21, 2024

Looks like we need to exclude the great-expectations plugin from acryl-datahub[all], or add the extra clause to install it alongside the rest of the docker build.

#18 ERROR: process "/bin/sh -c uv pip install --no-cache -e \".[base,all]\" \"./airflow-plugin[plugin-v2]\" &&     datahub --version" did not complete successfully: exit code: 1
------
 > importing cache manifest from acryldata/datahub-ingestion:pr11096:
------
------
 > importing cache manifest from acryldata/datahub-ingestion:1203cf0:
------
------
 > [full-install-build 3/4] RUN uv pip install --no-cache -e ".[base,all]" "./airflow-plugin[plugin-v2]" &&     datahub --version:
8.143   × No solution found when resolving dependencies:
8.143   ╰─▶ Because acryl-datahub-gx-plugin was not found in the package
8.143       registry and acryl-datahub[all]==1!0.0.0+docker.pr11096
8.143       depends on acryl-datahub-gx-plugin, we can conclude that
8.143       acryl-datahub[all]==1!0.0.0+docker.pr11096 cannot be used.
8.143       And because only acryl-datahub[all]==1!0.0.0+docker.pr11096 is
8.143       available and you require acryl-datahub[all], we can conclude that the
8.143       requirements are unsatisfiable.
------
Dockerfile:43
--------------------
  42 |     
  43 | >>> RUN uv pip install --no-cache -e ".[base,all]" "./airflow-plugin[plugin-v2]" && \
  44 | >>>     datahub --version
  45 |     RUN ./pyspark_jars.sh
--------------------
ERROR: failed to solve: process "/bin/sh -c uv pip install --no-cache -e \".[base,all]\" \"./airflow-plugin[plugin-v2]\" &&     datahub --version" did not complete successfully: exit code: 1

@hsheth2 hsheth2 changed the title ci: separate great-expectations action package feat: separate great-expectations action package Aug 21, 2024
@hsheth2 hsheth2 merged commit 9568a42 into datahub-project:master Aug 21, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants