Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/dremio): Dremio software jobs retrieval SQL query fix query error #11817

Merged
merged 10 commits into from
Nov 14, 2024
Merged

fix(ingest/dremio): Dremio software jobs retrieval SQL query fix query error #11817

merged 10 commits into from
Nov 14, 2024

Conversation

acrylJonny
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny mentioned this pull request Nov 7, 2024
Merged
5 tasks
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Nov 7, 2024
mayurinehate
mayurinehate approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment as to inconsistent type of queries_datasets across cloud and software would help for future readers.

@acrylJonny
Copy link
Contributor Author

Adding a comment as to inconsistent type of queries_datasets across cloud and software would help for future readers.

Added comment on dremio_sql_queries.py pointing to incorrect documentation.

@mayurinehate mayurinehate merged commit ab0b0a2 into datahub-project:master Nov 14, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acrylJonny @mayurinehate