-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/cassandra): Add support for Cassandra as a source #11822
feat(ingest/cassandra): Add support for Cassandra as a source #11822
Conversation
dc5c84b
to
56b339a
Compare
Things to confirm:
|
set -> ArrayType
list -> ArrayType And UDT -> Flattened structure |
Views & Tables should have the same aspects
And ensure we have table + column comments as description fields. .....And Views have
|
Table + Column Comments should be QA'd locally. |
Also please make sure error handling is clear. And try-excepts are around areas where we need. This connector should only fail in known cases. We should not have ANY uncaught exceptions! |
d8ecb9c
to
2d8f887
Compare
2d8f887
to
f089c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_utils.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_utils.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
31f887e
to
7929bd2
Compare
7929bd2
to
5b61cbb
Compare
5b61cbb
to
5534e0c
Compare
48954d4
to
ee56ad8
Compare
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_utils.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_utils.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_api.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/cassandra/cassandra_config.py
Show resolved
Hide resolved
6170060
to
a5f9f0f
Compare
74ff00e
to
3186e79
Compare
1d3a5e9
to
2600d7b
Compare
2600d7b
to
f7dd7aa
Compare
Checklist