-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metadata-ingestion): implement mlflow source #7971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me and thanks so much for your contribution! Sorry for the delay in the review. I just have a few docs / style suggestions and a couple requested changes as we've updated our Source infrastructure.
Hi @hariishaa, I think this is super close. Are you still looking to get this through? |
@asikowitz, yeah... Have some time management problems 🙄 Hope to make all the changes soon |
Hi @asikowitz! I've resolved all your comments 🙂 Now waiting for the approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for the contribution!
Merging through what looks like test flakes |
Hi! I would like to make a contribution to DataHub project with a source for MLflow Model Registry. There is another abandoned PR with the same purpose (#2725) but it looks too outdated and it is primarily based on ingesting metadata from MLflow Experiments. In my opinion, a more appropriate solution is to make a source implementation based on Model Registry instead. So I decided to create the ingestion source for the latest version of MLflow from scratch.
Checklist