Enable stats header row wrapping and expandable counts #8343
Conversation
joshuaeilers
changed the title
| <EntityTitle onClick={onClick} $titleSizePx={titleSizePx}> | ||
| {name || ' '} | ||
| </EntityTitle> | ||
| <FirstRow> |
There was a problem hiding this comment.
The changes to the jsx are:
- Wraps the left/right columns in a FirstRow
- Wraps the stats (subheader) in a SecondRow
- Moves the subHeader to the SecondRow
There was a problem hiding this comment.
this makes sense! I'd ask that before merging we do one more manual test to ensure things look good in all the different variations where there are stats, when there's no stats, when there's tags, terms, owners, lots of them, none of them, etc.
The reason I ask is because this component is notoriously fickle and lots of things rely on other things as you can see by the messy code below here...
| @@ -7,31 +7,34 @@ type Props = { | |||
| }; | |||
|
|
|||
| const StatsContainer = styled.div` | |||
There was a problem hiding this comment.
can we maybe add a minor padding/margin to the bottom? even like 4px or something. it looks a little tight on the bottom of the card between the stats and edge of card!
| <EntityTitle onClick={onClick} $titleSizePx={titleSizePx}> | ||
| {name || ' '} | ||
| </EntityTitle> | ||
| <FirstRow> |
There was a problem hiding this comment.
this makes sense! I'd ask that before merging we do one more manual test to ensure things look good in all the different variations where there are stats, when there's no stats, when there's tags, terms, owners, lots of them, none of them, etc.
The reason I ask is because this component is notoriously fickle and lots of things rely on other things as you can see by the messy code below here...
| `; | ||
|
|
||
| const DomainWrapper = styled.span` | ||
| display: inline-block; | ||
| margin-bottom: 8px; |
There was a problem hiding this comment.
I believe this DomainLink (and the DataProductLink and tags below) are all used in the sidebar on profile pages. do things still look good there with these CSS changes?
There was a problem hiding this comment.
yeah I think the spacing may be a little off in that sidebar. you can always wrap the components like DomainLink in a new spacer span styled component with margin-bottom:8px; for that specific use case! probably better there anyways than forcing styles everywhere it's used.
Stats regressed somewhat after #8232 where each column was wrapping and became hard to read. Previously, overflow content would wrap to the next line. This PR adds that behavior back in and also fixes a small bug where popovers were opening inside of a tooltip. This also expands upon the expansion functionality of the hover for more fields.
Checklist