Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datahub-frontend): Add playCaffeine as replacement for removed playEhcache dependency #8344

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

MideO
Copy link
Contributor

@MideO MideO commented Jun 30, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This is to resolve the issue described in #7733

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jun 30, 2023
@MideO MideO changed the title fix(datahub-frontne): Reinstate missing playEhcache dependency fix(datahub-frontend): Reinstate missing playEhcache dependency Jul 4, 2023
@RyanHolstien
Copy link
Collaborator

The EhCache implementation is deprecated and considered legacy, can this be done using the play Caffeine impl?: https://mvnrepository.com/artifact/com.typesafe.play/play-caffeine-cache

See:
Play provides a CacheApi implementation based on [Caffeine](https://github.com/ben-manes/caffeine/) and a legacy implementation based on [Ehcache 2.x](http://www.ehcache.org/). For in-process caching Caffeine is typically the best choice. If you need distributed caching, there are third-party plugins for [memcached](https://github.com/mumoshu/play2-memcached) and [redis](https://github.com/KarelCemus/play-redis).

https://www.playframework.com/documentation/2.8.x/ScalaCache

@MideO MideO changed the title fix(datahub-frontend): Reinstate missing playEhcache dependency fix(datahub-frontend): Add playCaffience as replacement for removed playEhcache dependency Jul 11, 2023
@MideO
Copy link
Contributor Author

MideO commented Jul 11, 2023

@RyanHolstien Thanks for the feedback, I've replaced play Ehcache with Caffeine.

@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jul 17, 2023
@RyanHolstien RyanHolstien changed the title fix(datahub-frontend): Add playCaffience as replacement for removed playEhcache dependency fix(datahub-frontend): Add playCaffeine as replacement for removed playEhcache dependency Jul 19, 2023
@RyanHolstien
Copy link
Collaborator

This looks good to me, just waiting on CI to be green. We're actively working on fixing some flakiness so hoping your PR can get in after that.

@MideO
Copy link
Contributor Author

MideO commented Nov 27, 2023

bump @iprentic @RyanHolstien please can we get this merged in?

@RyanHolstien RyanHolstien added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 27, 2023
@anshbansal anshbansal merged commit c946d26 into datahub-project:master Nov 29, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants