-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datahub-frontend): Add playCaffeine as replacement for removed playEhcache dependency #8344
Conversation
The EhCache implementation is deprecated and considered legacy, can this be done using the play Caffeine impl?: https://mvnrepository.com/artifact/com.typesafe.play/play-caffeine-cache See: https://www.playframework.com/documentation/2.8.x/ScalaCache |
…layEhcache dependency
@RyanHolstien Thanks for the feedback, I've replaced play Ehcache with Caffeine. |
This looks good to me, just waiting on CI to be green. We're actively working on fixing some flakiness so hoping your PR can get in after that. |
bump @iprentic @RyanHolstien please can we get this merged in? |
Checklist
This is to resolve the issue described in #7733