Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datahub-ingestion): refactor slim image to add vs remove pyspark… #8509

Closed
wants to merge 3 commits into from
Closed

feat(datahub-ingestion): refactor slim image to add vs remove pyspark… #8509

wants to merge 3 commits into from

Conversation

david-leifker
Copy link
Collaborator

… deps

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs devops PR or Issue related to DataHub backend & deployment labels Jul 25, 2023
hsheth2
hsheth2 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tweak, but otherwise lgtm

docker/docker-compose-with-cassandra.yml Outdated
@@ -24,7 +24,7 @@ services:
datahub-actions:
container_name: datahub-actions
hostname: actions
image: acryldata/datahub-actions:${ACTIONS_VERSION:-head}
image: acryldata/datahub-actions${ACTIONS_BASE:}:${ACTIONS_VERSION:-head}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just make the whole thing configuration e.g. DATAHUB_ACTIONS_IMAGE, and have it default to acryldata/datahub-actions

That's similar to our approach for all other images like DATAHUB_FRONTEND_IMAGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@pedro93 pedro93 Awaiting requested review from pedro93

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @hsheth2