Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native versioning on docs #8512

Closed
wants to merge 149 commits into from

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Jul 26, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub


We might have to trigger the algolia crawler manually after deployment, to enable versioning search

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jul 26, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Jul 28, 2023

I'm not a huge fan of the amount of copying here - would it be possible for the entire versioned_docs/version-0.10.4 directory to live in the static assets repo as a tar.gz file, and then pull it in during the docs build process?

kkorchak and others added 25 commits August 24, 2023 16:32
@hsheth2
Copy link
Collaborator

hsheth2 commented Aug 26, 2023

Closing this as outdated.

@hsheth2 hsheth2 closed this Aug 26, 2023
@yoonhyejin yoonhyejin deleted the docs/versioning-static-asset branch December 11, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.