Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datahub-ingestion): refactor datahub ingestion slim images #8515

Merged
merged 33 commits into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
d37df26
feat(datahub-ingestion): refactor slim image to add vs remove pyspark…
david-leifker Jul 25, 2023
e18e4ec
refactor smoke-test dependency on actions pod
david-leifker Jul 26, 2023
cab4537
set fetch depth
david-leifker Jul 27, 2023
7031b06
Merge branch 'master' into refactor-actions-slim
david-leifker Jul 27, 2023
95321a2
bump plugin
david-leifker Jul 27, 2023
cd1757a
try pruning
david-leifker Jul 27, 2023
02295bc
non-standalone
david-leifker Jul 27, 2023
7deee6e
add conditional build datahub-ingestion unified
david-leifker Jul 27, 2023
d146ac2
Merge branch 'master' into refactor-actions-slim
david-leifker Jul 27, 2023
337888c
Fix tests
david-leifker Jul 28, 2023
efaf896
Merge branch 'master' into refactor-actions-slim
david-leifker Jul 28, 2023
f499fa0
Merge remote-tracking branch 'datahub-project/master' into refactor-a…
david-leifker Jul 29, 2023
77f1773
Merge branch 'master' into refactor-actions-slim
treff7es Jul 31, 2023
846d95b
fix(test): increase siblings.js test stability
david-leifker Aug 1, 2023
05c9dad
Merge branch 'master' into siblings-cypress-fix
david-leifker Aug 1, 2023
69dae5c
Merge remote-tracking branch 'origin/master' into refactor-actions-slim
david-leifker Aug 1, 2023
2846d2f
Merge remote-tracking branch 'origin/siblings-cypress-fix' into refac…
david-leifker Aug 1, 2023
f257f07
re-enable standalone mode
david-leifker Aug 1, 2023
23b1eb3
Merge remote-tracking branch 'origin/master' into refactor-actions-slim
david-leifker Aug 2, 2023
f2e2d72
add brackets to conditionals
david-leifker Aug 2, 2023
5d27e33
split base/full/slim
david-leifker Aug 2, 2023
aba2ec8
restore normal actions pod for gradle task `quickstart`
david-leifker Aug 3, 2023
236024e
test new datahub-ingestion workflow
david-leifker Aug 9, 2023
309863b
Update docker-unified.yml
david-leifker Aug 9, 2023
dde6bba
Update docker-unified.yml
david-leifker Aug 9, 2023
2e98da0
Update docker-unified.yml
david-leifker Aug 9, 2023
7004177
Update docker-unified.yml
david-leifker Aug 9, 2023
88643c3
Merge remote-tracking branch 'origin/master' into refactor-actions-slim
david-leifker Aug 12, 2023
4908544
fixup slim build
david-leifker Aug 12, 2023
8a1db8d
Merge branch 'refactor-actions-slim' of github.com:datahub-project/da…
david-leifker Aug 12, 2023
516fc20
capture actions logs
david-leifker Aug 14, 2023
3d0bbc1
ensure path
david-leifker Aug 15, 2023
587ac2d
updates per review
david-leifker Aug 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/actions/docker-custom-build-and-push/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ inputs:
# e.g. latest,head,sha12345
description: "List of tags to use for the Docker image"
required: true
target:
description: "Sets the target stage to build"
required: false
outputs:
image_tag:
description: "Docker image tags"
Expand Down Expand Up @@ -62,6 +65,7 @@ runs:
platforms: linux/amd64
build-args: ${{ inputs.build-args }}
tags: ${{ steps.docker_meta.outputs.tags }}
target: ${{ inputs.target }}
load: true
push: false
- name: Upload image locally for testing (if not publishing)
Expand Down Expand Up @@ -92,6 +96,7 @@ runs:
platforms: ${{ inputs.platforms }}
build-args: ${{ inputs.build-args }}
tags: ${{ steps.docker_meta.outputs.tags }}
target: ${{ inputs.target }}
push: true

# TODO add code for vuln scanning?
45 changes: 0 additions & 45 deletions .github/workflows/docker-ingestion-base.yml
Original file line number Diff line number Diff line change
@@ -1,45 +0,0 @@
name: ingestion base
on:
release:
types: [published]
push:
branches:
- master
paths:
- ".github/workflows/docker-ingestion-base.yml"
- "docker/datahub-ingestion-base/**"
- "gradle*"
pull_request:
branches:
- master
paths:
- ".github/workflows/docker-ingestion-base.yml"
- "docker/datahub-ingestion-base/**"
- "gradle*"
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
build-base:
name: Build and Push Docker Image to Docker Hub
runs-on: ubuntu-latest
steps:
- name: Check out the repo
uses: actions/checkout@v3
with:
fetch-depth: 800
- name: Build and Push image
uses: ./.github/actions/docker-custom-build-and-push
with:
images: |
acryldata/datahub-ingestion-base
tags: latest
username: ${{ secrets.ACRYL_DOCKER_USERNAME }}
password: ${{ secrets.ACRYL_DOCKER_PASSWORD }}
publish: ${{ github.ref == 'refs/heads/master' }}
context: .
file: ./docker/datahub-ingestion-base/Dockerfile
platforms: linux/amd64,linux/arm64/v8
118 changes: 0 additions & 118 deletions .github/workflows/docker-ingestion.yml

This file was deleted.

Loading
Loading