Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): fix lightning cache enable logic #8522

Merged
merged 2 commits into from
Jul 28, 2023
Merged

fix(search): fix lightning cache enable logic #8522

merged 2 commits into from
Jul 28, 2023

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Jul 28, 2023 •
edited
Loading

Moved the logic to remove degree filter from slow cache to apply to both slow and fast caching.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jul 28, 2023
shirshanka
shirshanka approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-leifker david-leifker merged commit fa05aae into datahub-project:master Jul 28, 2023
35 checks passed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@david-leifker @yoonhyejin
fix(search): fix lightning cache enable logic (#8522)
01baea5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @shirshanka @RyanHolstien