Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ingest): Bump pydantic pin #8660

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

asikowitz
Copy link
Collaborator

https://docs.pydantic.dev/latest/changelog/#v1100-2022-08-30 changelog was very long but I didn't see anything serious. This may not be necessary but we saw some errors on older pydantic versions, and pydantic no longer hosts docs for versions below 1.10

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 August 17, 2023 15:48
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 17, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@anshbansal anshbansal merged commit 68abf9c into datahub-project:master Aug 23, 2023
48 of 50 checks passed
@anshbansal
Copy link
Collaborator

Failures not related to ingestion code

asikowitz added a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants