Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): skip publish step on PRs from forks #8661

Closed
wants to merge 2 commits into from

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 17, 2023

Fixes a subtle regression from #8515.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Aug 17, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 17, 2023
@asikowitz
Copy link
Collaborator

Looks like those 2 stages are consistently failing

@asikowitz
Copy link
Collaborator

asikowitz commented Aug 17, 2023

Seems like we have another check with different logic:

        if: ${{ needs.setup.outputs.publish != 'true' }}

and we go back and forth on which we use... should prob be consistent here. Not sure if this is what's causing the error though

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Aug 17, 2023

@asikowitz lets see if this tweak does the trick

@asikowitz
Copy link
Collaborator

Doesn't look like it

@anshbansal
Copy link
Collaborator

anshbansal commented Aug 20, 2023

#8677 should supersede this. Please re-open if that PR does not work.

@anshbansal anshbansal closed this Aug 20, 2023
@hsheth2 hsheth2 deleted the fix-docker-ci branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants