fix(powerbi): fix access token expiry #8680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powerbi returns an expiry time for the access token which is currently ignored. This causes all api calls to fail after 60 minutes, which is the timeout returned by PowerBI. This commit fixes the bug by creating a new token once the old one expires.
github-actions
bot
added
the
ingestion
maggiehays
added
the
community-contribution
siddiquebagwan-gslab
suggested changes
Aug 24, 2023
| @@ -128,7 +130,7 @@ def get_authorization_header(self): | |||
| return {Constant.Authorization: self.get_access_token()} | |||
|
|
|||
| def get_access_token(self): | |||
| if self.__access_token is not None: | |||
| if self.__access_token is not None and self.__access_token_expiry_time > datetime.now(): | |||
There was a problem hiding this comment.
Could you please put the expiry condition check in a method is_token_expire()
|
@siddiquebagwan-gslab fixed |
siddiquebagwan-gslab
suggested changes
Aug 28, 2023
|
@siddiquebagwan-gslab seems that CI is stuck - is there a way to trigger it to run? (I tried to close and reopen the PR but that just removed your approval so now I need you to approve again) |
hsheth2
approved these changes
Sep 12, 2023
hsheth2
added
the
merge-pending-ci
elish7lapid
force-pushed
the
powerbi/fix-credentials-timeout
branch
from
97645e6
to
52e1ad4
Compare
Hi @elish7lapid |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powerbi returns an expiry time for the access
token which is currently ignored.
This causes all api calls to fail after 60 minutes, which is the timeout returned by PowerBI.
This commit fixes the bug by creating a new token
once the old one expires.
Checklist