Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add needs_artifact_download output for ingestion image #8695

Merged
merged 2 commits into from
Aug 23, 2023
Merged

ci: add needs_artifact_download output for ingestion image #8695

merged 2 commits into from
Aug 23, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 22, 2023 •
edited
Loading

Follow up on #8677.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Aug 22, 2023
david-leifker
david-leifker previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to follow a similar pattern for the full data-ingestion image security scan, even though its not needed for smoke-test.

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Aug 23, 2023

Merging through smoke test failures because this is unblocking CI.

@hsheth2 hsheth2 merged commit d6e36f1 into datahub-project:master Aug 23, 2023
50 of 51 checks passed
@hsheth2 hsheth2 deleted the docker-actions-tweak branch August 23, 2023 04:27
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@hsheth2 @asikowitz
ci: add needs_artifact_download output for ingestion image (datahub…
24f56f1 
…-project#8695)
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@hsheth2 @yoonhyejin
ci: add needs_artifact_download output for ingestion image (#8695)
2ee8932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

@david-leifker david-leifker david-leifker left review comments

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @asikowitz @david-leifker