fix non sibling document links #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
commented
Aug 24, 2023
| cy.get("[role='tab']").contains("Documentation").click(); | ||
| cy.get(`[href='${correct_url}']`).should("be.visible"); | ||
| }); | ||
| it("open test domain page, remove and add dataset link", () => { |
There was a problem hiding this comment.
New test, ignore weird diff to the dataset one. Indentation got all updated.
eboneil
approved these changes
Aug 24, 2023
github-actions
bot
added
product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had not accounted for documentation tab on other non-sibling entities when I previously tried to fix removing siblings document links.