Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health): Adding Entity Health Status to the Lineage Graph View #8739

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR, we add the Entity Health Status to the Lineage Graph View.

Note that we are not yet supporting Siblings. That will come in a followup PR.

Status

Ready for review

Screenshots

Screenshot 2023-08-28 at 4 10 55 PM Screenshot 2023-08-28 at 4 11 02 PM Screenshot 2023-08-28 at 4 02 01 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Aug 28, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! i think this will be so useful in the lineage view

@@ -359,6 +365,16 @@ export default function LineageEntityNode({
{getShortenedTitle(node.data.name, width)}
</UnselectableText>
)}
<foreignObject x={healthX} y={healthY} width="20" height="20">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love these foreignObject guys

@jjoyce0510 jjoyce0510 merged commit 4539a1c into datahub-project:master Aug 29, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants