feat(ingest/snowflake): allow shares config without platform instance #8803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Sep 8, 2023
| config = SnowflakeV2Config( | ||
| account_id="abc12345", | ||
| shares={ | ||
| "share1": SnowflakeShareConfig( |
There was a problem hiding this comment.
"db1" (primary, included in share) and "db2"(secondary, created from share) are present in this account, as present in snowflake_databases.
asikowitz
approved these changes
Sep 8, 2023
| "It is required to use `platform_instance` when ingesting from multiple snowflake accounts." | ||
| ) | ||
| if current_platform_instance is None: | ||
| logger.warning( |
There was a problem hiding this comment.
I'd make this an INFO, and perhaps explain what setting platform instance provides (i.e. no conflict for entities with the same name in each instance). I think there are valid use cases for not setting platform instance, e.g. you don't expect overlap or you're looking at different slices of the same data
|
Looks like you have a 3.7 lint failure -- missing type annotation. I'm confused how this passed 3.10 |
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist