ci: make wheel builds more robust #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Sep 12, 2023
| @@ -22,7 +22,7 @@ $(VENV_SENTINEL): requirements.txt | |||
| $(VENV_DIR)/bin/pip install -r requirements.txt | |||
| touch $(VENV_SENTINEL) | |||
|
|
|||
| .PHONY: help html doctest linkcheck clean serve md | |||
| .PHONY: help html doctest linkcheck clean clean_all serve md | |||
There was a problem hiding this comment.
Can remove clean from here since clean_all covers that
There was a problem hiding this comment.
yeah - doesn't hurt to have it, but agree that it's redundant
There was a problem hiding this comment.
actually this is the .PHONY rule so it's required here
| @@ -1,4 +1,4 @@ | |||
| -e ../../metadata-ingestion[datahub-rest] | |||
| -e ../../metadata-ingestion[datahub-rest,sql-parsing] | |||
There was a problem hiding this comment.
DataHubGraph has a lineage method that uses sqlglot, so this helps sphinx not complain
doesn't actually impact much though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist