Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column level lineage and path test #8822

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Column level lineage and path test #8822

merged 11 commits into from
Oct 24, 2023

Conversation

kkorchak
Copy link
Contributor

Test steps:

  1. Open Dataset with column-level lineage configured
  2. Navigate to Lineage tab -> Visualize Lineage
  3. Enable “Show Columns” switch
  4. Verify the functionality of column lineage
  5. Open dataset Impact Analysis view, enable Column Lineage
  6. Verify Upstream and Downstream column lineage
  7. Verify Column Path modal works as expected

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Sep 11, 2023
jjoyce0510
jjoyce0510 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from minor comment

@kkorchak kkorchak merged commit a0ce4f3 into datahub-project:master Oct 24, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkorchak @jjoyce0510