Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Corrects release version for custom ownership types. #8847

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat(docs): Corrects release version for custom ownership types. #8847

merged 3 commits into from
Oct 3, 2023

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 15, 2023 •
edited
Loading

Checklist

Fixes documentation around custom ownership type cli ingestion.

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Sep 15, 2023
@pedro93
Copy link
Collaborator Author

pedro93 commented Sep 22, 2023

@yoonhyejin When I try to access the Vercel deployment I don't see my documentation changes. Is that because the documentation github action failed?

@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 22, 2023

@pedro93 it's probably because you're looking at 0.11.0 instead of next

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 22, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 3, 2023

CI failure is unrelated, merging.

@hsheth2 hsheth2 merged commit 790011d into master Oct 3, 2023
54 of 55 checks passed
@hsheth2 hsheth2 deleted the update-ownership-docs branch October 3, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @hsheth2