Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display generic not found page for corp groups that do not exist #8880

Merged
merged 14 commits into from
Oct 11, 2023
Merged

fix: Display generic not found page for corp groups that do not exist #8880

merged 14 commits into from
Oct 11, 2023

Conversation

jayasimhankv
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

When trying to load a corp group that does not exist, the current UI shows a blank entity page, making it look it the entity does exist.
Example:
image

The change in this PR proposes to show the generic non existent entity page as is being done for other entities such as Datasets and Glossary Terms.
Example:
image

Please review and approve. Thanks.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 21, 2023
@jayasimhankv jayasimhankv changed the title Display generic not found page for corp groups that do not exist fix: Display generic not found page for corp groups that do not exist Sep 21, 2023
@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 7:39pm

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 4, 2023
jjoyce0510
jjoyce0510 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Thank you @jayasimhankv !

Will merge once green.

@jjoyce0510 jjoyce0510 enabled auto-merge (squash) October 11, 2023 22:07
@jjoyce0510 jjoyce0510 merged commit 245284e into datahub-project:master Oct 11, 2023
38 of 39 checks passed
@jayasimhankv
Copy link
Contributor Author

Looks great.

Thank you @jayasimhankv !

Will merge once green.

Thank you!, @jjoyce0510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

@chriscollins3456 chriscollins3456

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jayasimhankv @jjoyce0510 @maggiehays @chriscollins3456 @jkadambi