Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): Fix postgres lineage within views #8906

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix(ingest): Fix postgres lineage within views #8906

merged 4 commits into from
Oct 11, 2023

Conversation

harsha-mandadi-4026
Copy link
Contributor

@harsha-mandadi-4026 harsha-mandadi-4026 commented Sep 26, 2023 •
edited
Loading

  • When include_view_lineage is set to True and platform_instance is set to a value in a Postgres ingestion recipe, the lineage within views doesn't work.
  • The make_dataset_urn function is used instead of make_dataset_urn_with_platform_instance in the lineage resolving function. The make_dataset_urn function cannot resolve the upstream tables since it doesn't accept the platform_instance parameter.
  • So, I made a change to use the make_dataset_urn_with_platform_instance function instead of make_dataset_urn, ensuring that the lineage always works, whether or not a platform_instance value is present.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 26, 2023
@harsha-mandadi-4026 harsha-mandadi-4026 marked this pull request as draft September 26, 2023 16:02
@harsha-mandadi-4026 harsha-mandadi-4026 marked this pull request as ready for review September 27, 2023 08:57
hsheth2
hsheth2 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix!

fyi @mayurinehate

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 28, 2023
@hsheth2 hsheth2 added the community-contribution PR or Issue raised by member(s) of DataHub Community label Sep 29, 2023
@asikowitz
Copy link
Collaborator

Merging through flakes

@asikowitz asikowitz merged commit 4b6b941 into datahub-project:master Oct 11, 2023
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsha-mandadi-4026 @asikowitz @hsheth2 @maggiehays