Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/redshift): CLL support in redshift #8921

Conversation

siddiquebagwan-gslab
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 5:17pm

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One small tweak, but we can do that in a follow up when you add the SqlParserResult -> finegrained lineage conversion helper method

else:
return []
return [], cll
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return [], cll
return [], None

@hsheth2 hsheth2 merged commit 10a1904 into datahub-project:master Oct 11, 2023
54 checks passed
@yoonhyejin yoonhyejin added hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ and removed hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants