Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: data contracts models + CLI #8923

Merged
merged 18 commits into from
Oct 5, 2023
Merged

feat: data contracts models + CLI #8923

merged 18 commits into from
Oct 5, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 29, 2023

What's here

  • underlying PDL models for data contracts
  • associated datahub datacontract CLI

What's coming next

  • GraphQL APIs
  • UI rendering for data contracts

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Sep 29, 2023
shirshanka
shirshanka approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 merged commit 817c371 into datahub-project:master Oct 5, 2023
58 checks passed
@hsheth2 hsheth2 deleted the data-contracts-to-oss branch October 5, 2023 03:11
@yoonhyejin yoonhyejin added hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ and removed hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsheth2 @shirshanka @yoonhyejin @jjoyce0510