Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-product): show data product card on home page #8924

Merged
merged 2 commits into from
Oct 2, 2023
Merged

fix(data-product): show data product card on home page #8924

merged 2 commits into from
Oct 2, 2023

Conversation

Endtry
Copy link
Contributor

@Endtry Endtry commented Sep 29, 2023

Description

In this PR, I added EntityType.DataProduct into the view entity filter so that the DataProduct(s) will display as a card under "Explore your Data" section on the home page.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Sep 29, 2023
@Endtry Endtry force-pushed the lp--homepage-data-product-card branch from f55721e to 61b529d Compare September 29, 2023 20:40
chriscollins3456
chriscollins3456 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this looks good to me!

@chriscollins3456 chriscollins3456 merged commit c779b92 into datahub-project:master Oct 2, 2023
40 of 41 checks passed
@yoonhyejin yoonhyejin added hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ and removed hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Endtry @chriscollins3456 @yoonhyejin