fix(ingest): refactor test markers + fix disk space issues in CI #8938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
5 tasks
asikowitz
approved these changes
Oct 4, 2023
Comment on lines
+68
to
+74
| if ( | ||
| "docker_compose_runner" in item.fixturenames # type: ignore[attr-defined] | ||
| or any( | ||
| marker.name == "integration_batch_2" for marker in item.iter_markers() | ||
| ) | ||
| ): | ||
| item.add_marker(pytest.mark.slow) |
There was a problem hiding this comment.
Can we manually mark each test in this batch slow instead? Feels like this is something that'd be easy to miss
There was a problem hiding this comment.
we don't actually use slow anywhere, so I think it's fine - I mainly added it as a convenience thing to run quick unit tests locally
5 tasks
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the tests into integration_batch_{0,1,2}. If it's in the tests/integration directory, it gets labelled as an integration test. If it has an explicit batch number, that will be used. Otherwise, it will go in batch 0 by default.
Also renames
slow_integration->batch_2andslow_unittoslow. The slow marker isn't actually used for much yet.Root cause of the disk space issues seems to be the iceberg CI tests - the
tabulario/spark-icebergimage is 6.7gb uncompressed. This shuffles some of the tests between the batches and adds logic to remove some of the larger docker images after the integration test is done.Checklist