Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(style): Improve search bar input focus + styling #8955

Merged
merged 2 commits into from
Oct 5, 2023
Merged

refactor(style): Improve search bar input focus + styling #8955

merged 2 commits into from
Oct 5, 2023

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Oct 4, 2023 •
edited
Loading

  1. Add focus border
  2. Alter placeholder text
  3. Support command-k focus of the search input
  4. Fixed the View All Results for Query bug with quick filters (selecting quick filter automatically selected a query text). This is just a simplification. Any time there is a query we show the "View all results for" option now.

Moving ingestion nav tab to the far right (as per designs)

Screenshot 2023-10-04 at 1 31 29 PM Screenshot 2023-10-04 at 1 39 08 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

chriscollins3456
chriscollins3456 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool beans

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 4, 2023
@jjoyce0510 jjoyce0510 merged commit 0f8d275 into datahub-project:master Oct 5, 2023
39 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjoyce0510 @chriscollins3456 @maggiehays